Kryptronic Software Support Forum

It would be one of two things... the first possibility is that you skipped the first step of changing the Perform Order Updates field to 'Yes' for the check payment method.  If you don't change that setting, the script won't update the status to Pending Payment.  The other possibility would be some sort of error in the code in applying the code from one of the other two steps.

I set this mod up to work with the Contact Customer payment method and the Check payment method.  The way it stands, those are the only two that will move from incomplete to payment pending at the completion of the checkout process.  So you should change the update status for those two payment methods, but there isn't much point in changing it for any others, unless you also modify the code.  If there are other payment methods that you want to work this way (like maybe ones you've created), you can add the gateway names into the list in the if statement:

if ($tracking_paymethod =~ "ste_gw_nopay" or $tracking_paymethod =~ "ste_gw_check")

All the gateways listed there will be set to pending payment at the end of the transaction, as long as thier update status setting in the admin is 'yes'.

The 'Money Order' payment method is one I'm not familiar with, as it doesn't seem to be part of the standard CCP install.  If it's one you added, then it should probably be included in the if statement.  The only other payment method I see in the standard CCP install that should probably be included is the Purchase Order payment method.  PayPal and any of the credit card methods will update their status from incomplete to pending shipment or complete already and should NOT be included in this if statement.  This mod doesn't change the behavior of any of those payment methods, except to change the status of unfinished orders from 'pending payment' to 'incomplete'.  Those methods should also already be set to perform updates, so no change is required there and they will continue to update their status (when appropriate, of course) just like they did before.  This mod only affects payment methods that would normally have stopped at Pending Payment status, like check, contact customer, and purchase order.

I can see how that would be a problem.  I don't use drop shipping, so I hadn't forseen that situation.  There is another possible method, but I haven't tested it this way.  If you want to give it a try, here's what you need to do.  First, change your update status settings back to 'no'.  Leave the rest of the mod in place, as per the original post.  The alternate mod requires an additional change to ste_order.pl, in the subroutine ste_order_conf_updatetrack_proc.  Around line 3040 you'll find:

if ($tracking_status ne "C" && $gateway_updateallow eq "Y") {

Change the above line to:

if ($tracking_status ne "C" && ($gateway_updateallow eq "Y" or $tracking_paymethod =~ "ste_gw_nopay" or $tracking_paymethod =~ "ste_gw_check")) {

Again, you can add other payment methods to the list, such as purchase order or credit card by phone.  By leaving the update status setting set to 'no' and doing the mod this way, the status should update from incomplete to pending payment when the customer completes the order, but none of the other things (like shipper emails) will happen.  Like I said, this is untested; so give it a good thorough test and be prepared to revert to your backup if it does anything unexpected.

Rachael

I'm getting script execution error with the new code.

Bingo, working like a charm!

I applied this mod two weeks ago and only tested it making cancelled orders, it worked great. Then an actual order came in and this is what freaked out:

1. No order confirmation page is generated.

2. No tracking order is generated.

3. Order is marked incomplete and there is no state, zip code, or lots of other information.

4. An email is sent to the store, but there is no confirmation order sent to the customer.


Anyway, I put it back the old way until I can figure this out.

Gonna take some more information to sort that one out... what payment method... how was the mod applied... several people, including myself, have been using this without a problem, so it was probably an error in applying the mod.  Give us some details of what you did and we'll try to help.

The layaway mod certainly complicates things, since it would affect related portions of the code.  If what you've got is working for you, then that's great.  But I would be concerned about the three nested if statements at the beginning of the routine - that seems to set it up so that the code inside those if statements can never run.  I would double-check that credit card or other payment methods are still functioning properly and also try to follow through the code logic in that routine to make sure it does what it was supposed to.

This mod has evolved a little bit, so I'm going to post the complete instructions over again so that it is more clear.  This does not take into account the layaway mod, so if you have that module, either don't use this mod or see John's comments above.  Here are the new instructions to apply this mod:

This will involve several changes, so I recommend a full site backup before you begin.  At a minimum, make sure you back up the affected files before you modify them.  When you FTP, remember that CSV files need to be transferred in BINARY mode and PERL files (.pl) need to be transferred in ASCII mode.

First, edit the file ccp51/data/tabes/config_tracking.csv and change the line:

tracking_status,SYSTEM,Order Status,30,Y,SELECT-CUSTOM,Pending Payment:P|Pending Shipment:NS|Partially Shipped:PS|Completed:C|Cancelled:X,P,Y

to:

tracking_status,SYSTEM,Order Status,30,Y,SELECT-CUSTOM,Incomplete:P|Pending Payment:PP|Pending Shipment:NS|Partially Shipped:PS|Completed:C|Cancelled:X,P,Y

Next, edit the file cgi-bin/library/modules/ste_order.pl.  In the subroutine ste_order_conf_updatetrack_proc (somewhere around line 3020), change:

if ($prodshipped_count > "0") {

$dbins_tracking_status = database_quote('tracking','NS');

} else {

$dbins_tracking_status = database_quote('tracking','C');

} ######### End of if statement.

to:

if ($tracking_paymethod =~ "ste_gw_nopay" or $tracking_paymethod =~ "ste_gw_check" or $tracking_paymethod =~ "ste_gw_purchord") {

  $dbins_tracking_status = database_quote('tracking','PP');

} else {

  if ($prodshipped_count > "0") {

  $dbins_tracking_status = database_quote('tracking','NS');

  } else {

  $dbins_tracking_status = database_quote('tracking','C');

  } ######### End of if statement.

} #### endif

Finally, still in ste_order.pl, in the subroutine ste_order_conf_updatetrack_proc, around line 3010 you'll find:

if ($tracking_status ne "C" && $gateway_updateallow eq "Y") {

Change the above line to:

if ($tracking_status ne "C" && ($gateway_updateallow eq "Y" or $tracking_paymethod =~ "ste_gw_nopay" or $tracking_paymethod =~ "ste_gw_check" or $tracking_paymethod =~ "ste_gw_purchord")) {

With the mod in place this way, no shipper emails will go out, nor will discount codes and inventory update when pending payment orders are placed.  I believe this covers all the appropriate payment methods that come with the standard CCP install.  However, if you have created payment methods of your own that require the same behavior, you can add them to the end of the list of payment methods in both places by putting in:

or $tracking_paymethod =~ "ste_gw_yourmethod"

Sorry for any confusion the premature posting of the mod might have caused.

Rachael

Last edited by rachaelseven (09-29-2006 08:33:34)

HI Bob,

You're very welcome.  In answer to your questions:

1)  As far as the ATS batch page goes, I assume you mean to have the pending payment orders show up there?  If that's the case, then what you want to do is edit adm_batch.pl and look for the code:

  $SQL = "select tracking_id,tracking_firstname,tracking_lastname,tracking_date,tracking_total,tracking_shippingtotal,tracking_stateprovtax, tracking_countrytax, tracking_discounttotal,tracking_usr,tracking_phone,tracking_fax,tracking_email,tracking_status from tracking where tracking_status = 'NS' or tracking_status = 'PS' order by tracking_epoch asc";

And change that to:

  $SQL = "select tracking_id,tracking_firstname,tracking_lastname,tracking_date,tracking_total,tracking_shippingtotal,tracking_stateprovtax, tracking_countrytax, tracking_discounttotal,tracking_usr,tracking_phone,tracking_fax,tracking_email,tracking_status from tracking where tracking_status = 'NS' or tracking_status = 'PS' or tracking_status = 'PP' order by tracking_epoch asc";

I don't think you would want the incomplete orders to show, but if you did for some reason, you could add:

 or tracking_status = 'P'

That would go right after the 'PP' in the code above.

2) I don't know of an easy way to track payments over time with CCP.  I've been thinking about offering Net 30 terms to a few of my dealers as well, so I have been giving it some thought.  But so far, I don't have a good option.  I'm thinking that maybe that would really need to be done in an accounting software and I might need to figure out the accounting export portion of CCP and deal with it that way.  But if I do have any good thoughts for modding CCP, I'll definitely let you know.  Do you have any sense of what the functionality should be?  If you can define the way it should work, I might be able to work out the code or we could approach a support partner if it looks too complex.

Rachael

Last edited by rachaelseven (09-29-2006 08:34:06)

Hi Bob,

No, you're not missing anything - I am.  I didn't think about the necessity of adding the new radio button for the new status... sorry about that.  The SQL statement you have should pull the incomplete orders, but we'll need another change to make a radio button for the incomplete status.  Edit your adm_batch.pl one more time and look for the code:

    print "<td valign='top'>";
    print "<input type='hidden' name='tracking_id$OnRow' value='$tracking_id'>\n";
    print "<input type='hidden' name='tracking_oldstatus$OnRow' value='$tracking_status'>\n";
    $selected = ($tracking_status eq "P" ? " CHECKED" : "");
    print "<input type='radio' value='P' name='tracking_status$OnRow'$selected>Pending Payment<br>\n";
    $selected = ($tracking_status eq "NS" ? " CHECKED" : "");
    print "<input type='radio' value='NS' name='tracking_status$OnRow'$selected>Pending Shipment<br>\n";
    $selected = ($tracking_status eq "PS" ? " CHECKED" : "");
    print "<input type='radio' value='PS' name='tracking_status$OnRow'$selected>Partially Shipped<br>\n";
    print "<input type='radio' value='C' name='tracking_status$OnRow'>Completed<br>\n";
    print "<input type='radio' value='X' name='tracking_status$OnRow'>Cancelled\n";
    print "</td>";

And change that code to:

    print "<td valign='top'>";
    print "<input type='hidden' name='tracking_id$OnRow' value='$tracking_id'>\n";
    print "<input type='hidden' name='tracking_oldstatus$OnRow' value='$tracking_status'>\n";
    $selected = ($tracking_status eq "P" ? " CHECKED" : "");
    print "<input type='radio' value='P' name='tracking_status$OnRow'$selected>Incomplete<br>\n";
    $selected = ($tracking_status eq "PP" ? " CHECKED" : "");
    print "<input type='radio' value='PP' name='tracking_status$OnRow'$selected>Pending Payment<br>\n";
    $selected = ($tracking_status eq "NS" ? " CHECKED" : "");
    print "<input type='radio' value='NS' name='tracking_status$OnRow'$selected>Pending Shipment<br>\n";
    $selected = ($tracking_status eq "PS" ? " CHECKED" : "");
    print "<input type='radio' value='PS' name='tracking_status$OnRow'$selected>Partially Shipped<br>\n";
    print "<input type='radio' value='C' name='tracking_status$OnRow'>Completed<br>\n";
    print "<input type='radio' value='X' name='tracking_status$OnRow'>Cancelled\n";
    print "</td>";

I honestly haven't fully tested this, since I don't pull incomplete or pending payment orders in my batch page; but I'm pretty confident it should work for you.  Let me know how it goes.

Rachael

Last edited by rachaelseven (09-29-2006 08:34:31)